Example:
I am a bit at a loss when it comes to providing a meaningful test case that illustrates the problem, as I did in the previous posts in this series.
Based on my current understanding we would have to show that the randomness of the results matches a uniform random distribution. But lets look at the solutions first. I will come back to that question at the end.
Solution:
There are at least three solutions to this problem that I am aware of.
1. Idiomatic/Java Interop
The first one is to reuse the idiomatic variant of the randomselect, which is based on java.util.Collections#shuffle, which in turn implements AFAIK the well known FisherYates shuffle algorithm. While a functional purist might sniff at the mutation involved I think, this is perfectly fine in this case as the mutability is encapsulated in a functional/immutable shell. Your sequence is translated into a mutable collection to use the efficient algorithm based on swapping. The result is then transformed back into a persistent data structure: a pattern often used to get the best of both worlds.
2. Naive Functional
Solution number two is functional but not very efficient. If I am not mistaken the running time of this solution should be O(n^2). We are calling removeat n times, which calls splitat. Splitat has linear complexity.
3. Perfect Functional Shuffle
The third solution is nothing I came up with myself. I merely followed a hint given by Phil Gold. It pointed to Oleg Kiselyov's post about perfect functional shuffle in Haskell.
Implementing it in Clojure turned out to be quite a lot of work. I have never done any Haskell and I am not sure if I got all of if right. It is probably best you have a look at Oleg's text first.
I did not read up much on Haskell syntax, but nonetheless: it started to make sense after looking at the code for a while even without knowing the language. The biggest difference with effects on the structure of the program: Haskell comes with continuation passing style built right in— something I could not or did not want to recreate in Clojure.
The gist of the solution is to build a binary tree out of the input sequence. The tree allows for efficient extraction of branches and is by its very nature at most ceil(log2 n) deep. The overall complexity of the solution should be therefore O(n*log n). Again, read the original text for more detail.
I decided to use core.match and add with it the first dependency to the project. This allowed me to stick closer to the original solution which makes heavy use of Haskell's pattern matching.
Translating the essential two functions was pretty straightforward and core.match offered all I needed. The syntax is a bit clunkier (notably the guard clauses) than Haskell's succinctness but it's not in a different ballpark alltogether.
The first interesting function is called pairleaves. It takes a sequence of nodes—initially all leaves—(represented by vectors of the form [:node:leaf count value]) and joins them together to form a binary tree. We need four pattern matches to do that: matching two leaves, a node and a leaf, a leaf and a node and finally one matching two nodes.
This gives us the binary tree. We now take a sequence of random numbers (each being an independent sample of a uniform random distribution [0...n1]) and extract the numbers at the positions indicated by those random indices from the tree.
We need six pattern matches to extract from the tree. (Oleg needs five as Haskell apparently has something like a multiple guard with subbranches which spares him writing the last match.) The patterns are:

The first element is always a leaf on the left.
 Any but the first element when our tree consists of two leaves: the right leaf.
 Any but the first element where our tree is bigger than two leaves: extract recursively to the right.
 Any but the first element where n + 1 is equal to (or greater)
than the count of the root node and we have a leaf as the
right subtree. This is actually the biggest deviation from Oleg's
code and possibly a mistake on my part.
 The last two are closely related: a tree with a nonleaf subtree to the
left and none of the above: if the number we are looking for is in
the left subtree (as indicated by its count on the node) we
recursivly extract to the left, otherwise to the right.
Verifying the Results
What is left to do is to verify the property of uniform random distribution. The assumtions about time complexity as outlined by Oleg seem obvious to me. Let's look at a histogram:
This histogram left me wondering whether I had made a mistake. It does seem to show a quite clearly discernible repetitive sawtooth pattern. I created the data with this snippet of Clojure:
(def input '[a b c d e]) (def perms (vec (combo/permutations input))) (def samples (repeatedly 10000 (fn [] (.indexOf perms (randompermutefunctional input)))))
Compare this with a histogram of 10000 results generated by the first solution based on FisherYates:
The most likely explanation is a mistake in my implementation or my reasoning. I have not found it yet, but I am quite keen on any hints. Could it be that perfect functional shuffle is not quite perfect? Probably not.
Update:
Of course not. Andy Fingerhut was so kind to point out my mistake to me: You have to choose the random numbers uniformly distributed within [0,n1] for the first number, [0, n2] for the second number and so on. Otherwise you will bias your shuffle towards whatever is the rightmost branch of your tree, as every number > n where n is the size of your current tree will extract the rightmost element. You can find the corrected version here. The histogram looks much better now too:
No comments:
Post a Comment